ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Adopt Ansible's non-injected facts style across CI and documentation to prepare for upcoming deprecations.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in integration test workflows so CI runs with fact injection disabled.
• Propagate an SR_ANSIBLE_INJECT_FACT_VARS flag through the TFT workflow environment to align tests with the new Ansible fact handling behavior.

Documentation:

• Update README-ostree to reference ansible_facts-based distribution variables instead of deprecated fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates CI workflows to run Ansible with fact injection disabled by default and aligns documentation wording with the new ansible_facts-style variable access, helping catch deprecated fact usage early.

File-Level Changes

Change	Details	Files
Run Ansible in CI with fact variables injection disabled to surface deprecated fact usage.	Set ANSIBLE_INJECT_FACT_VARS environment variable to "false" in the qemu-kvm integration tests workflow. Propagate an SR_ANSIBLE_INJECT_FACT_VARS=false variable through the TFT workflow Terraform invocation so downstream jobs can respect the same setting.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml
Align README documentation with ansible_facts-based fact access rather than injected variables.	Update description of DISTRO-VERSION to reference ansible_facts["distribution"] and ansible_facts["distribution_version"] instead of deprecated ansible_distribution and ansible_distribution_version.	README-ostree.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the README-ostree update, consider briefly noting that ansible_distribution/ansible_distribution_version are deprecated aliases of ansible_facts["distribution"]/["distribution_version"] (with a link to the porting guide) so readers understand why the naming changed.
• You introduced SR_ANSIBLE_INJECT_FACT_VARS in the TFT workflow; ensure the Terraform/test harness layer actually maps this through to ANSIBLE_INJECT_FACT_VARS so the behavior is consistent with the qemu-kvm workflow.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the README-ostree update, consider briefly noting that `ansible_distribution`/`ansible_distribution_version` are deprecated aliases of `ansible_facts["distribution"]`/`["distribution_version"]` (with a link to the porting guide) so readers understand why the naming changed.
- You introduced `SR_ANSIBLE_INJECT_FACT_VARS` in the TFT workflow; ensure the Terraform/test harness layer actually maps this through to `ANSIBLE_INJECT_FACT_VARS` so the behavior is consistent with the qemu-kvm workflow.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}