ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container tox environment names with new ansible-core naming scheme.

CI:

• Bump tox-lsr used in GitHub Actions workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environments in CI matrices from dot-based to dash-based version identifiers to avoid tox 4.x Python version parsing issues.

Documentation:

• Adjust contributing guide qemu tox example to use the new dash-based qemu-ansible-core environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to work with tox 4.49 by renaming qemu/container ansible-core tox environments to use dash-separated version identifiers and by bumping tox-lsr to 3.16.0 across GitHub workflows and documentation.

File-Level Changes

Change	Details	Files
Align GitHub Actions qemu/container CI matrix with new dash-based tox environment naming to avoid tox 4.x mis-parsing versions.	Rename qemu ansible-core tox env names from major.minor to major-minor in the matrix (e.g., qemu-ansible-core-2.16 -> qemu-ansible-core-2-16). Rename container ansible-core tox env names from major.minor to major-minor, including commented-out matrix entries. Keep image matrix and other workflow logic unchanged.	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr version used in CI workflows to 3.16.0.	Update pip install commands in multiple workflows to pull tox-lsr@3.16.0 instead of 3.15.0. Leave other package installation logic and workflow steps intact.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Adjust contributor documentation example to use new dash-based qemu tox environment name.	Change the sample tox command in contributing.md to reference qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14, reflecting both the naming change and a newer ansible-core version. Do not modify surrounding explanatory text or other examples.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The contributing.md example was changed from qemu-ansible-core-2.14 to qemu-ansible-core-2-20; if the intent was only to adjust the naming scheme, consider keeping the same ansible-core version (e.g. 2-14) to avoid confusing readers about version support changes.
• After renaming the tox environments from x.y to x-y in the workflows, double-check that any corresponding env names in tox.ini and helper scripts are updated consistently so CI and local runs use the same identifiers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The contributing.md example was changed from `qemu-ansible-core-2.14` to `qemu-ansible-core-2-20`; if the intent was only to adjust the naming scheme, consider keeping the same ansible-core version (e.g. `2-14`) to avoid confusing readers about version support changes.
- After renaming the tox environments from `x.y` to `x-y` in the workflows, double-check that any corresponding env names in tox.ini and helper scripts are updated consistently so CI and local runs use the same identifiers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}