ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

[richm]

tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.1 and ensure container tests always configure required plugins.

Bug Fixes:

• Ensure container tests consistently configure the required connection plugin by no longer skipping callback/connection plugin setup between test runs.

CI:

• Bump tox-lsr dependency from 3.17.0 to 3.17.1 across GitHub Actions workflows.
• Fix indentation in qemu-kvm integration workflow and simplify environment flags used during repeated test execution.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and stops skipping callback/connection plugin setup on subsequent tox runs in the qemu-kvm integration workflow.

Sequence diagram for container tests using tox_lsr_3_17_1

sequenceDiagram
    actor Developer
    participant GitHubActions
    participant tox_lsr_3_17_1 as tox_lsr_3_17_1
    participant AnsibleContainerTests

    Developer->>GitHubActions: Push_commit_open_PR
    GitHubActions->>tox_lsr_3_17_1: Install_tox_lsr_version_3_17_1
    GitHubActions->>tox_lsr_3_17_1: Run_tox_env_for_container_tests

    tox_lsr_3_17_1->>tox_lsr_3_17_1: Setup_connection_plugin_directory
    tox_lsr_3_17_1->>tox_lsr_3_17_1: Setup_callback_plugins
    tox_lsr_3_17_1->>tox_lsr_3_17_1: Set_ANSIBLE_CONNECTION_PLUGINS_env

    tox_lsr_3_17_1->>AnsibleContainerTests: Invoke_ansible_test_with_connection_plugin
    AnsibleContainerTests-->>GitHubActions: Container_tests_pass_or_fail
    GitHubActions-->>Developer: Report_CI_status

Loading

File-Level Changes

Change	Details	Files
Update all GitHub Actions workflows to use tox-lsr 3.17.1 so container tests pick up the connection-plugin fix.	Bump tox-lsr version from 3.17.0 to 3.17.1 in qemu-kvm-integration-tests workflow. Bump tox-lsr version from 3.17.0 to 3.17.1 in ansible-lint workflow. Bump tox-lsr version from 3.17.0 to 3.17.1 in ansible-managed-var-comment workflow. Bump tox-lsr version from 3.17.0 to 3.17.1 in ansible-test workflow. Bump tox-lsr version from 3.17.0 to 3.17.1 in python-unit-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Ensure callback/connection plugin setup is always executed in qemu-kvm container integration tests rather than being skipped after the first run.	Remove SKIP_CALLBACK_PLUGINS environment variable export before the test loop to guarantee plugin setup always runs. Remove SKIP_CALLBACK_PLUGINS environment variable toggle inside the test loop so later tests do not skip plugin setup. Fix indentation for the yq-based galaxy_tags check in the scenario support detection shell snippet.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}