generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 7
ci: skip most CI checks if title contains citest skip [citest_skip] #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdd a conditional guard to most GitHub Actions CI workflows so that their jobs are skipped when the pull request title contains the substring "[citest_skip]". Sequence diagram for GitHub Actions job execution with [citest_skip] in PR titlesequenceDiagram
actor Developer
participant GitHub
participant Workflow_ansible_lint
participant Workflow_codespell
participant Workflow_markdownlint
participant Workflow_codeql
participant Workflow_woke
Developer->>GitHub: Open or update pull request
GitHub->>GitHub: Read github.event.pull_request.title
alt PR title contains [citest_skip]
GitHub->>Workflow_ansible_lint: Evaluate if condition
Workflow_ansible_lint-->>GitHub: Condition false, job skipped
GitHub->>Workflow_codespell: Evaluate if condition
Workflow_codespell-->>GitHub: Condition false, job skipped
GitHub->>Workflow_markdownlint: Evaluate if condition
Workflow_markdownlint-->>GitHub: Condition false, job skipped
GitHub->>Workflow_codeql: Evaluate if condition
Workflow_codeql-->>GitHub: Condition false, job skipped
GitHub->>Workflow_woke: Evaluate if condition
Workflow_woke-->>GitHub: Condition false, job skipped
else PR title does not contain [citest_skip]
GitHub->>Workflow_ansible_lint: Start job ansible_lint
Workflow_ansible_lint-->>GitHub: Run CI steps
GitHub->>Workflow_codespell: Start job codespell
Workflow_codespell-->>GitHub: Run CI steps
GitHub->>Workflow_markdownlint: Start job markdownlint
Workflow_markdownlint-->>GitHub: Run CI steps
GitHub->>Workflow_codeql: Start job analyze
Workflow_codeql-->>GitHub: Run CI steps
GitHub->>Workflow_woke: Start job woke
Workflow_woke-->>GitHub: Run CI steps
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- For workflows that are also triggered by non-PR events (e.g.,
push,scheduleincodeql.yml), referencinggithub.event.pull_request.titlecan be undefined; consider guarding the condition withgithub.event_name == 'pull_request'to avoid evaluation issues, e.g.if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]'). - Since the same skip condition is duplicated across many jobs, consider extracting it into a common pattern (e.g., top-level
ifper workflow or a reusable workflow) to keep things consistent and easier to maintain if the rule changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For workflows that are also triggered by non-PR events (e.g., `push`, `schedule` in `codeql.yml`), referencing `github.event.pull_request.title` can be undefined; consider guarding the condition with `github.event_name == 'pull_request'` to avoid evaluation issues, e.g. `if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')`.
- Since the same skip condition is duplicated across many jobs, consider extracting it into a common pattern (e.g., top-level `if` per workflow or a reusable workflow) to keep things consistent and easier to maintain if the rule changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <[email protected]>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.