Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 10, 2026

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

CI:

  • Update all GitHub Actions workflows to install tox-lsr version 3.15.0 instead of 3.14.0.

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner February 10, 2026 16:09
@richm richm self-assigned this Feb 10, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the tox-lsr dependency from version 3.14.0 to 3.15.0 across all GitHub Actions workflows so CI runs (including qemu-based integration tests) use the updated tooling that restores IPv6 support in qemu VMs.

Flow diagram for qemu_kvm_integration_tests CI job using tox_lsr_3_15_0

flowchart TD
  GH[GitHub_push_or_PR_event]
  J[qemu_kvm_integration_tests_workflow_job]
  S1[Checkout_repository]
  S2[Install_tox_and_tox_lsr_3_15_0]
  S3[Run_tox_lsr_test_environment]
  S4[Start_qemu_VMs_with_IPv6_support]
  S5[Execute_integration_tests]
  S6[Collect_results_and_set_job_status]

  GH --> J
  J --> S1
  S1 --> S2
  S2 --> S3
  S3 --> S4
  S4 --> S5
  S5 --> S6
Loading

File-Level Changes

Change Details Files
Update tox-lsr version used in GitHub Actions workflows to 3.15.0.
  • Change pip3 installation of tox-lsr from 3.14.0 to 3.15.0 in ansible-lint workflow.
  • Change pip3 installation of tox-lsr from 3.14.0 to 3.15.0 in ansible-managed-var-comment workflow.
  • Change pip3 installation of tox-lsr from 3.14.0 to 3.15.0 in ansible-test workflow.
  • Change pip installation of tox-lsr from 3.14.0 to 3.15.0 in python-unit-test workflow.
  • Change pip3 installation of tox-lsr from 3.14.0 to 3.15.0 in qemu-kvm-integration-tests workflow, which is relevant for restored IPv6 support in qemu VMs.
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the tox-lsr version is duplicated across multiple workflows, consider centralizing it (e.g., as a reusable workflow input or a shared env variable) to make future version bumps less error-prone.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the tox-lsr version is duplicated across multiple workflows, consider centralizing it (e.g., as a reusable workflow input or a shared env variable) to make future version bumps less error-prone.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 37d6b34 into main Feb 10, 2026
14 checks passed
@richm richm deleted the tox-lsr-3.15.0 branch February 10, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant