generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 7
ci: Add Fedora 43, remove Fedora 41 from Testing Farm CI #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Fedora 43, remove Fedora 41 from Testing Farm CI Signed-off-by: Rich Megginson <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Testing Farm CI to drop Fedora 41 support and add Fedora 43, including corresponding matrix entries and supported platform detection logic in the GitHub Actions workflow. Flow diagram for updated supported_platforms detection and matrix in Testing Farm CIflowchart TD
A[Start tft job] --> B[Set meta_main meta/main.yml]
B --> C{galaxy_tags contains fedora}
C -->|yes| D[Append Fedora-42 to supported_platforms]
D --> E[Append Fedora-43 to supported_platforms]
C -->|no| F[Skip generic Fedora platforms]
E --> G[Check galaxy_tags for fedoraN pattern]
F --> G
G --> H[Build matrix include list]
H --> I[Add Fedora-42 ansible_2_19]
I --> J[Add Fedora-43 ansible_2_20]
J --> K[Add CentOS-7-latest ansible_2_9]
K --> L[Add CentOS-Stream-8]
L --> M[Run Testing Farm tests for each matrix platform]
M --> N[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since the workflow determines supported platforms from
meta/main.ymlgalaxy tags, make sure the role metadata is updated to add Fedora 43 and drop Fedora 41 so the dynamicsupported_platformslogic aligns with the matrix changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the workflow determines supported platforms from `meta/main.yml` galaxy tags, make sure the role metadata is updated to add Fedora 43 and drop Fedora 41 so the dynamic `supported_platforms` logic aligns with the matrix changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fedora 43, remove Fedora 41 from Testing Farm CI
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Update Testing Farm GitHub Actions workflow to adjust Fedora versions used in CI matrix.
CI: