Conversation
…r fedora 43 [citest_skip] tox-lsr 3.17.0 has some container test improvements - better output, faster runs Use Ansible 2.20 for qemu/container tests on fedora 43 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.0 and bump Fedora 43 Ansible environments to ansible-core 2.20, while refining container test execution behavior for better performance and output control. Flow diagram for GitHub_Actions_job_installing_and_using_tox_lsr_3_17_0flowchart TD
A["Job start in GitHub Actions"] --> B["Checkout repository"]
B --> C["Set shell options: set -euxo pipefail"]
C --> D["Install tox-lsr 3.17.0 via pip3:\npip3 install git+https://github.com/linux-system-roles/tox-lsr@3.17.0"]
D --> E["Run tox-lsr managed test environment"]
E --> F{"Test type"}
F --> G["Ansible lint / plugin scan"]
F --> H["Ansible tests (including container and QEMU)"]
F --> I["Python unit tests"]
G --> J["Collect results and logs"]
H --> J
I --> J
J --> K["Job status reported back to GitHub"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version is hard-coded in multiple workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or workflow env) to avoid inconsistent future bumps.
- For the new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS toggling in the container test loop, a brief rationale in comments about why the first run must not skip and subsequent runs can would help future maintainers avoid inadvertently changing this behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version is hard-coded in multiple workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or workflow env) to avoid inconsistent future bumps.
- For the new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS toggling in the container test loop, a brief rationale in comments about why the first run must not skip and subsequent runs can would help future maintainers avoid inadvertently changing this behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.0 has some container test improvements - better output, faster runs
Use Ansible 2.20 for qemu/container tests on fedora 43
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use newer testing tooling and optimize container-based test execution.
CI: