feat: Support this role in container environments and builds #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize qemu-kvm-integration-tests.yml to run some "container-*" environments as well. For "classic rpm" OSes that does not give us too much beyond making sure that the container tests actually work (developers might use them locally, after all). 90% of the logic (setup, compatibility check, status updates, etc.) is the same, so it's not economic to duplicate all of that into a new workflow. Add Fedora/CentOS *-bootc scenarios: These check that our role works during a bootc container build, without any systemd, processes, or other runtime environment. tox-lsr added support for this in linux-system-roles/tox-lsr#188. However, as most roles don't currently work in that environment, introduce and check a new `containerbuild` tag in meta/main.yml. We'll add this to roles as we adjust them. Similarly, as not every role works in a running container (e.g. due to assuming SELinux), check a new `container` tag in their tests. See https://issues.redhat.com/browse/RHEL-78157
Feature: Support running this role during container builds and in container environments. Reason: This is particularly useful for building bootc derivative OSes. It's also desirable to run roles in system containers. Result: These flags enable running the container scenarios in CI, which ensures that the role works in podman system containers as well as buildah build environment and thus allows us to officially support this role for image mode builds. Actual roles may opt out of this by dropping the corresponding tag.
martinpitt
force-pushed
the
bootc-container-test
branch
from
9d1be2b to
618793f
Compare
richm
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Support running this role during container builds and in
container environments.
Reason: This is particularly useful for building bootc derivative OSes.
It's also desirable to run roles in system containers.
Result: These flags enable running the container scenarios in CI, which
ensures that the role works in podman system containers as well as
buildah build environment and thus allows us to officially support this
role for image mode builds.
Actual roles may opt out of this by dropping the corresponding tag.