test: ensure tests cleanup and restore the system state #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the tests cleanup and restore the system state. Refactor tests to use a `block/always` so that cleanup can occur in the `always` block. Add a tests/tasks/cleanup.yml tasks file which is run from the `always` block of the test, and include this task file to be run from the `always` block of tests that require cleanup. Signed-off-by: Rich Megginson <[email protected]>
Collaborator
Author
|
[citest] |
Collaborator
Author
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the tests cleanup and restore the system state.
Refactor tests to use a
block/alwaysso that cleanup canoccur in the
alwaysblock.Add a tests/tasks/cleanup.yml tasks file which is run from
the
alwaysblock of the test, and include this task fileto be run from the
alwaysblock of tests that require cleanup.Signed-off-by: Rich Megginson [email protected]