Conversation
This adds back support for IPv6 in qemu VMs, which appears to be working now. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.15.0 instead of 3.14.0 so CI, including qemu-based integration tests, runs with the newer tooling that restores IPv6 support in qemu VMs. Flow diagram for GitHub Actions tox_lsr_version_updateflowchart TD
A["Workflow_dispatch_or_push"] --> B["Checkout_repository"]
B --> C["Install_tox_lsr_3_15_0_via_pip"]
C --> D1["Convert_role_to_collection_format_(ansible_lint_workflow)"]
C --> D2["Run_ansible_plugin_scan_(managed_var_comment_workflow)"]
C --> D3["Run_qemu_kvm_integration_tests_with_IPv6_support"]
D1 --> E["Report_lint_status"]
D2 --> F["Post_or_update_ansible_managed_var_comment"]
D3 --> G["Report_integration_test_status"]
E --> H["Overall_CI_status"]
F --> H
G --> H
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the tox-lsr version is duplicated across multiple workflows, consider centralizing it via a reusable workflow, composite action, or a single env variable so that future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the tox-lsr version is duplicated across multiple workflows, consider centralizing it via a reusable workflow, composite action, or a single env variable so that future version bumps only require a single change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds back support for IPv6 in qemu VMs, which appears to be working now.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: