Fix urlopen() for Python 2 in runqemu.py #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_metadata_from_url()` previousl fell back to urllib.urlopen() on HTTPErrors, due to its overly wide `except` (never catch `Exception`!), which leads to unnecessarily long and confusing backtraces. Other places did not have a Python 2 fallback at all. Directly import the `urlopen` function from the respective module to simplify the code. Also drop the unused `urllib.parse` import.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/tox_lsr/test_scripts/runqemu.py:152
- In Python 2, the object returned by urlopen may not support the context manager protocol. Consider implementing a wrapper or using a try/finally block to ensure proper resource cleanup when running in Python 2.
with urlopen(url) as url_response: # nosec
richm
approved these changes
Apr 11, 2025
Contributor
Author
|
another instance from today. Makes me think we should intercept that error and retry a few times with exponential back-off. |
Contributor
Yes, sounds good. |
Contributor
Author
|
Done in #185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_metadata_from_url()previousl fell back to urllib.urlopen() on HTTPErrors, due to its overly wideexcept(never catchException!), which leads to unnecessarily long and confusing backtraces.Other places did not have a Python 2 fallback at all. Directly import the
urlopenfunction from the respective module to simplify the code.Also drop the unused
urllib.parseimport.Spotted in linux-system-roles/firewall#258 in this run
Tested with
sudo pip install ~/upstream/lsr/tox-lsrand running firewall qemu tox tests locally.