libkirk/events: register the event handler for suite_timeout#30
Merged
acerv merged 1 commit intolinux-test-project:masterfrom Feb 12, 2025
Merged
libkirk/events: register the event handler for suite_timeout#30acerv merged 1 commit intolinux-test-project:masterfrom
acerv merged 1 commit intolinux-test-project:masterfrom
Conversation
In our testing, we find when suite timeout happened, nothing is printed. and it confuses us that many tests are skipped but no hint in the log. We find the handler is there but not registered, so add it there. With the line added, we'll have the log like below when suite timeout happened: Suite 'syscalls' timed out after 3600 seconds. Signed-off-by: Chunyu Hu <chuhu@redhat.com>
Collaborator
|
Thanks for catching it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our testing, we find when suite timeout happened, nothing is printed. and it confuses us that many tests are skipped but no hint in the log. We find the handler is there but not registered, so add it there.
With the line added, we'll have the log like below when suite timeout happened:
Suite 'syscalls' timed out after 3600 seconds.