Skip to content

Handle spaces in path/filename - see #350 #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Handle spaces in path/filename - see #350 #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
56a8874
Missed files in initial commit - see #343
henry2cox Dec 18, 2024
7eab748
Add 'py2lcov --cmd exe ..' option, so user can specify the name of th…
henry2cox Dec 18, 2024
9101cac
Bug in 'gitversion' script.
henry2cox Dec 18, 2024
96ace67
Another typo
henry2cox Dec 18, 2024
a8290ae
Merge branch 'linux-test-project:master' into master
henry2cox Dec 18, 2024
afdec49
Portability issues in 'simple' testcase. See #343.
henry2cox Dec 18, 2024
4da45db
Merge branch 'linux-test-project:master' into master
henry2cox Dec 18, 2024
0849d87
Handle spaces in path/filename. See #350.
henry2cox Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/py2lcov
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ Example:
while os.path.exists(xml):
xml = base + '.xml%d' % suffix
suffix += 1
cmd = 'COVERAGE_FILE=%s %s xml -o %s' % (f, args.cover_cmd, xml)
cmd = "COVERAGE_FILE='%s' '%s' xml -o '%s'" % (f, args.cover_cmd, xml)
try:
#x = subprocess.run(cmd, capture_output=True, shell=True, check=True)
x = subprocess.run(cmd, shell=True, check=True, stdout=True, stderr=True)
Expand Down
2 changes: 1 addition & 1 deletion bin/xml2lcovutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def close(self):
self._outf.close()

if self._args.version and None == self._versionScript:
cmd = "%(lcov)s -a %(info)s -o %(info)s --version-script '%(vers)s' %(checksum)s--rc compute_file_version=1 --branch-coverage --ignore inconsistent" % {
cmd = "'%(lcov)s' -a '%(info)s' -o '%(info)s' --version-script '%(vers)s' %(checksum)s--rc compute_file_version=1 --branch-coverage --ignore inconsistent" % {
'lcov': os.path.join(os.path.split(sys.argv[0])[0], 'lcov'),
'checksum': "--checksum " if self._args.checksum else '',
'info': self._args.output,
Expand Down