Testcase portability: default to git unless obviously p4 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Cox <[email protected]>
hartwork
reviewed
Jan 11, 2025
| @@ -248,7 +248,7 @@ if [ 0 != $? ] ; then | |||
| exit 1 | |||
| fi | |||
| fi | |||
| grep -E "#.*user:.+$USER" context_comment.info | |||
| grep "#user: $USER" context_comment.info | |||
There was a problem hiding this comment.
@henry2cox with the new text, we could add -F on top?
There was a problem hiding this comment.
@henry2cox update: this change can probably be just reverted (in favor of pull request #383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default to git unless obviously p4
Signed-off-by: Henry Cox [email protected]