fix: 修复dde-open识别不了空文件的问题 #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
当识别到空文件, 在尝试调用gio的guess方法通过文件名来识别MIME类型,如果还是识别不出来,默认使用text/plain Log: dde-open增强文件识别 Influence: MIME
Reviewer's guide (collapsed on small PRs)Reviewer's GuideHandle empty-file MIME detection in dde-open by falling back to gio-based content type guessing and defaulting to text/plain, and update deepin go dependencies to newer revisions. Sequence diagram for dde-open empty-file MIME resolutionsequenceDiagram
participant User
participant dde_open
participant gio
User->>dde_open: openFile(filename)
dde_open->>dde_open: Detect contentType from file
alt contentType is empty
dde_open-->>User: error failed to get file content type
else contentType == application/x-zerosize
dde_open->>gio: ContentTypeGuess(filename, nil)
gio-->>dde_open: uncerten, guessedType
alt uncerten is true or guessedType empty
dde_open->>dde_open: Set contentType to text/plain
else guessedType == application/x-zerosize
dde_open->>dde_open: Set contentType to text/plain
else guessedType valid
dde_open->>dde_open: Set contentType to guessedType
end
dde_open->>gio: AppInfoGetDefaultForType(contentType, false)
gio-->>dde_open: appInfo
alt appInfo is nil
dde_open-->>User: error no default app
else appInfo found
dde_open->>gio: Launch app with appInfo
gio-->>User: Application opens file
end
else non empty and known contentType
dde_open->>gio: AppInfoGetDefaultForType(contentType, false)
gio-->>dde_open: appInfo
alt appInfo is nil
dde_open-->>User: error no default app
else appInfo found
dde_open->>gio: Launch app with appInfo
gio-->>User: Application opens file
end
end
Flow diagram for openFile MIME detection with empty file handlingflowchart TD
A[Start openFile] --> B[Read file and detect contentType]
B --> C{contentType empty?}
C -- Yes --> D[Return error failed to get file content type]
C -- No --> E{contentType == application/x-zerosize?}
E -- No --> I[Use contentType to get default app via gio.AppInfoGetDefaultForType]
E -- Yes --> F[Call gio.ContentTypeGuess with filename]
F --> G{uncerten is true or guessedType empty?}
G -- Yes --> H[Set contentType to text/plain]
G -- No --> J{guessedType == application/x-zerosize?}
J -- Yes --> H
J -- No --> K[Set contentType to guessedType]
H --> I
K --> I
I --> L{appInfo is nil?}
L -- Yes --> M[Return error no default app]
L -- No --> N[Launch app with appInfo]
N --> O[End openFile]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个diff进行审查：
改进建议：
uncertain, guessedType := gio.ContentTypeGuess(filename, nil)
if uncertain || guessedType == "" {
logger.Debug("Failed to guess content type for empty file, using text/plain")
contentType = "text/plain"
}
const defaultContentType = "text/plain"总体来说，这是一个很好的改进，提高了对空文件的处理能力，代码质量良好，没有明显的问题。 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The variable name
uncertenis likely a typo foruncertain; consider renaming it to improve readability and avoid confusion. - The conditional branches handling
guessedTyperepeat theapplication/x-zerosizecheck and empty-string case; you could simplify by treating both as a single fallback path totext/plainto make the logic clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The variable name `uncerten` is likely a typo for `uncertain`; consider renaming it to improve readability and avoid confusion.
- The conditional branches handling `guessedType` repeat the `application/x-zerosize` check and empty-string case; you could simplify by treating both as a single fallback path to `text/plain` to make the logic clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BLumia
approved these changes
Nov 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当识别到空文件, 在尝试调用gio的guess方法通过文件名来识别MIME类型,如果还是识别不出来,默认使用text/plain
Log: dde-open增强文件识别
Influence: MIME
Summary by Sourcery
Improve dde-open MIME type detection for empty files and update core linuxdeepin Go dependencies.
Bug Fixes:
Enhancements:
Build: