-
Notifications
You must be signed in to change notification settings - Fork 51
fix: update linker flags for enhanced security hardening #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Modified GOBUILD_OPTIONS in debian/rules to include additional security hardening flags 2. Changed from "-pie" only to "-Wl,-z,relro,-z,now,-pie" for comprehensive security 3. This change applies to all architectures except mips64el 4. The new flags enable full RELRO (Relocation Read-Only) and BIND_NOW for immediate binding Log: Improved binary security with additional hardening flags Influence: 1. Test that the package builds successfully on all supported architectures except mips64el 2. Verify that the resulting binaries have proper security hardening enabled 3. Check that the application functionality remains unchanged with the new linker flags 4. Test on architectures where the change applies (non-mips64el) to ensure no regressions 5. Verify that mips64el builds continue to use the original flags without changes fix: 更新链接器标志以增强安全加固 1. 修改 debian/rules 中的 GOBUILD_OPTIONS 以包含额外的安全加固标志 2. 从仅使用 "-pie" 改为 "-Wl,-z,relro,-z,now,-pie" 以实现全面的安全保护 3. 此更改适用于除 mips64el 之外的所有架构 4. 新标志启用完整的 RELRO(重定位只读)和 BIND_NOW 以实现立即绑定 Log: 通过额外的加固标志提高了二进制文件的安全性 Influence: 1. 测试软件包在除 mips64el 之外的所有支持架构上是否成功构建 2. 验证生成的二进制文件是否启用了适当的安全加固 3. 检查应用程序功能在使用新链接器标志后是否保持不变 4. 在应用更改的架构(非 mips64el)上进行测试,确保没有回归问题 5. 验证 mips64el 架构的构建是否继续使用原始标志而不受影响 PMS: BUG-339571
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Debian packaging build rules to strengthen linker security hardening for Go binaries by expanding the default PIE linker flags on all architectures except mips64el. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个 git diff 进行详细的代码审查:
建议:
总的来说,这是一个很好的安全增强改动,符合现代软件安全最佳实践。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Log: Improved binary security with additional hardening flags
Influence:
fix: 更新链接器标志以增强安全加固
Log: 通过额外的加固标志提高了二进制文件的安全性
Influence:
PMS: BUG-339571
Summary by Sourcery
Build: