-
Notifications
You must be signed in to change notification settings - Fork 51
chore: remove unused gtk-thumbnailer module #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Removed gtk-thumbnailer from TESTS list in Makefile 2. Removed gtk-thumbnailer from BINARIES list in Makefile 3. Deleted main.go file containing GTK thumbnail generation logic 4. Deleted thumbnail.c file with GTK widget rendering implementation 5. Cleaned up build system to exclude this unused component This change removes the gtk-thumbnailer module which was no longer needed in the project. The module contained CGO-based GTK thumbnail generation code that created visual previews of GTK themes. Since this functionality is no longer required or maintained, removing it simplifies the codebase, reduces maintenance overhead, and eliminates unused dependencies on GTK libraries. Influence: 1. Verify that the project builds successfully without the gtk- thumbnailer module 2. Ensure no other components depend on the removed gtk-thumbnailer functionality 3. Test that all remaining tests in the TESTS list still pass 4. Confirm that all remaining binaries in the BINARIES list build correctly 5. Check that the build system doesn't reference the removed files elsewhere chore: 移除未使用的 gtk-thumbnailer 模块 1. 从 Makefile 的 TESTS 列表中移除 gtk-thumbnailer 2. 从 Makefile 的 BINARIES 列表中移除 gtk-thumbnailer 3. 删除包含 GTK 缩略图生成逻辑的 main.go 文件 4. 删除包含 GTK 部件渲染实现的 thumbnail.c 文件 5. 清理构建系统以排除此未使用的组件 此更改移除了项目中不再需要的 gtk-thumbnailer 模块。该模块包含基于 CGO 的 GTK 缩略图生成代码,用于创建 GTK 主题的视觉预览。由于此功能不再需要或维 护,移除它可以简化代码库,减少维护开销,并消除对 GTK 库的未使用依赖。 Influence: 1. 验证项目在没有 gtk-thumbnailer 模块的情况下能成功构建 2. 确保没有其他组件依赖于已移除的 gtk-thumbnailer 功能 3. 测试 TESTS 列表中所有剩余的测试是否仍然通过 4. 确认 BINARIES 列表中所有剩余的二进制文件能正确构建 5. 检查构建系统是否在其他地方引用了已移除的文件
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the unused gtk-thumbnailer module by deleting its source files and stripping it from the build/test configuration so it is no longer built, tested, or referenced by the build system. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这次代码变更进行审查:
总结: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This change removes the gtk-thumbnailer module which was no longer needed in the project. The module contained CGO-based GTK thumbnail generation code that created visual previews of GTK themes. Since this functionality is no longer required or maintained, removing it simplifies the codebase, reduces maintenance overhead, and eliminates unused dependencies on GTK libraries.
Influence:
chore: 移除未使用的 gtk-thumbnailer 模块
此更改移除了项目中不再需要的 gtk-thumbnailer 模块。该模块包含基于 CGO 的
GTK 缩略图生成代码,用于创建 GTK 主题的视觉预览。由于此功能不再需要或维
护,移除它可以简化代码库,减少维护开销,并消除对 GTK 库的未使用依赖。
Influence:
Summary by Sourcery
Remove the deprecated gtk-thumbnailer component from the codebase and build outputs.
Build:
Chores: