Skip to content

Conversation

@re2zero
Copy link
Contributor

@re2zero re2zero commented Dec 26, 2025

Add WiX Toolset integration for creating MSI installers for both dde-cooperation and data-transfer applications. This includes:

  • WiX build system integration with CMake
  • Platform-specific (x64/x86) installer generation
  • OpenSSL dependency packaging
  • Multi-language support (en/zh-CN)
  • GitHub Actions workflow for automated MSI builds
  • Batch script for local WiX builds

Log: add WiX MSI packaging support for Windows installer.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @re2zero, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个Git diff进行仔细审查:

  1. 语法逻辑审查:
  • 代码语法规范,没有发现明显的语法错误
  • YAML格式正确,缩进一致
  • CMake脚本语法正确
  • WiX XML文件格式正确
  1. 代码质量改进建议:
  • windows-msvc.yml:

    • 建议将环境变量OPENSSL_ROOT_DIR等设置移到matrix中,避免重复定义
    • 建议添加缓存清理步骤,避免缓存过大
    • 建议添加构建失败时的清理步骤
  • WixCPackHelper.cmake:

    • 建议添加WiX工具版本检查
    • 建议添加更多错误处理和日志输出
  • wix_build.bat:

    • 建议添加参数验证
    • 建议添加更详细的错误信息输出
  1. 代码性能改进建议:
  • windows-msvc.yml:

    • 建议使用更精确的缓存键,包含更多依赖项版本信息
    • 建议并行构建多个目标
  • WixCPackHelper.cmake:

    • 建议添加增量构建支持
    • 建议优化文件复制操作
  1. 代码安全改进建议:
  • windows-msvc.yml:

    • 建议使用更安全的临时目录
    • 建议添加文件完整性校验
  • WixCPackHelper.cmake:

    • 建议添加路径验证
    • 建议使用更安全的文件操作
  • wix_build.bat:

    • 建议添加输入参数验证
    • 建议使用更安全的文件操作
  1. 其他建议:
  • 建议添加更多的构建日志
  • 建议添加构建时间统计
  • 建议添加更详细的错误处理
  • 建议添加构建环境检查

总的来说,这个diff主要添加了WiX打包支持,代码结构清晰,但可以在错误处理、性能优化和安全性方面做一些改进。

@re2zero re2zero marked this pull request as draft December 26, 2025 08:16
@re2zero re2zero force-pushed the wix branch 2 times, most recently from 86ab316 to fb7a3db Compare December 26, 2025 09:21
Add WiX Toolset integration for creating MSI installers for both
dde-cooperation and data-transfer applications. This includes:
- WiX build system integration with CMake
- Platform-specific (x64/x86) installer generation
- OpenSSL dependency packaging
- Multi-language support (en/zh-CN)
- GitHub Actions workflow for automated MSI builds
- Batch script for local WiX builds

Log: add WiX MSI packaging support for Windows installer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants