Skip to content

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 3, 2024

Processing password unedited and not visible

pms: BUG-287123

robertkill
robertkill previously approved these changes Dec 3, 2024
Processing password unedited and not visible

pms: BUG-287123
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • NetPasswordEdit.qml中新增了dataItem属性,但未在代码中看到对该属性的使用,可能需要进一步确认其用途。
  • SectionPPPOE.qmlSectionVPN.qmlSystemProxyConfigItem.qml等文件中,将D.PasswordEdit替换为NetPasswordEdit,但未看到NetPasswordEdit的实现细节,无法评估替换是否合理。
  • SystemProxyConfigItem.qml中,config.user.length拼写错误,应为config.user.length
  • SystemProxyConfigItem.qml中,userAlertpasswordAlert属性被替换为errorKey,但未看到相应的逻辑更新,可能会导致功能异常。
  • SystemProxyConfigItem.qml中,showAlert属性在NetPasswordEdit中直接使用errorKey,但未看到errorKey的初始化或更新逻辑,可能会导致显示错误信息时出现问题。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit a3420fc into linuxdeepin:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants