Skip to content

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 3, 2024

Modifying VPN configuration file without naming issue

pms: BUG-287091

Modifying VPN configuration file without naming issue

pms: BUG-287091
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • PageVPNSettings.qml文件中,新增的currentFile属性可能会在未初始化的情况下使用,应该确保root.config.connection.id在赋值之前已经被正确初始化。
  • currentFile的赋值使用了root.config.connection.id,需要确认root.config.connection.id的值是有效的文件路径,否则可能会导致文件选择对话框打开时显示错误的默认文件。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 9e77a92 into linuxdeepin:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants