fix: Personal hotspot status when modifying airplane mode

[caixr23]

Personal hotspot status when modifying airplane mode

pms: BUG-303529

Summary by Sourcery

Fix personal hotspot functionality when airplane mode is enabled

Bug Fixes:

• Prevent personal hotspot configuration and usage when airplane mode is active by adding an isAirplane property to control visibility and interaction

Enhancements:

• Improve network page UI by adding a conditional visibility mechanism for hotspot-related elements during airplane mode

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 代码重构：

   • 在PageAirplane.qml和PageHotspot.qml中，D.Switch组件被包裹在Item组件中，但没有使用Item组件的其他属性。可以考虑直接使用D.Switch组件，减少不必要的嵌套。
   • 在PageHotspot.qml中，D.Switch的enabled属性现在依赖于isAirplane变量，这可能会导致逻辑错误。如果isAirplane为true，则D.Switch应该被禁用，而不是保持enabledable的值。

2. 逻辑错误：

   • 在PageHotspot.qml中，D.Switch的onClicked事件处理程序中，当checked为false时，应该执行NetManager.Disconnect操作，而不是注释掉的dccData.exec(NetManager.Disconnect, item.id, { "uuid": config["connection"]["uuid"] })。

3. 可见性控制：

   • 在PageHotspot.qml和PageWiredDevice.qml中，DccObject的visible属性被设置为!isAirplane，这可能会导致在isAirplane为true时，这些组件仍然可见。应该检查这些组件的可见性逻辑是否正确。

4. 代码风格：

   • 在PageHotspot.qml和PageWiredDevice.qml中，D.Switch组件被包裹在RowLayout组件中，但没有使用RowLayout组件的其他布局属性。如果RowLayout是必要的，应该添加适当的布局属性，否则应该移除RowLayout。

5. 国际化：

   • 在PageHotspot.qml和PageWirelessDevice.qml中，qsTr函数用于国际化字符串。确保所有字符串都被正确翻译，并且qsTr函数的使用是正确的。

6. 性能考虑：

   • 在PageHotspot.qml中，isAirplane属性被设置为dccData.root.isEnabled。如果dccData.root.isEnabled是一个昂贵的操作，应该考虑缓存这个值，以避免在每次onClicked事件时都进行计算。

7. 安全性：

   • 在PageHotspot.qml中，config["connection"]["uuid"]被直接用于字符串比较。如果config对象的结构可能会改变，应该添加适当的错误处理，以防止潜在的运行时错误。

综上所述，代码重构、逻辑错误、可见性控制、代码风格、国际化、性能考虑和安全性是代码审查中需要关注的主要方面。

[github-actions]

TAG Bot

TAG: 2.0.53
EXISTED: yes
DISTRIBUTION: unstable

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug where the personal hotspot status was not correctly updated when airplane mode was toggled. The hotspot functionality is now disabled when airplane mode is enabled, and a message is displayed to the user. The switch controls in PageAirplane.qml, PageHotspot.qml, PageWiredDevice.qml, and PageWirelessDevice.qml were refactored to use an Item as a parent.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Modified the hotspot page to disable hotspot functionality when airplane mode is enabled.	Added an isAirplane property to the PageHotspot.qml to track the airplane mode status. Bound the enabled property of the hotspot switch to item.enabledable && !isAirplane to disable it when airplane mode is on. Hid hotspot-related menu items when airplane mode is enabled. Displayed a message indicating that airplane mode needs to be disabled to use the personal hotspot when airplane mode is enabled.	dcc-network/qml/PageHotspot.qml
Added isAirplane property to the personalHotspot DccObject.	Added isAirplane property to the personalHotspot DccObject and bound it to dccData.root.isEnabled.	dcc-network/qml/networkMain.qml
Refactored the switch control in PageAirplane.qml, PageHotspot.qml, PageWiredDevice.qml, and PageWirelessDevice.qml to use an Item as a parent.	Wrapped the D.Switch control with an Item in PageAirplane.qml, PageHotspot.qml, PageWiredDevice.qml, and PageWirelessDevice.qml. Used anchors.fill: parent to make the switch fill the parent item.	dcc-network/qml/PageAirplane.qml dcc-network/qml/PageHotspot.qml dcc-network/qml/PageWiredDevice.qml dcc-network/qml/PageWirelessDevice.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @caixr23 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a more descriptive name than isAirplane for the property in PageHotspot.qml to better reflect its purpose.
• It seems like the Item component in PageHotspot.qml and PageAirplane.qml is only used for setting implicitWidth and implicitHeight - is it necessary?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment