-
Notifications
You must be signed in to change notification settings - Fork 48
fix: import QtQml.Models #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ListModel needs to import QtQml.Models pms: BUG-307817
deepin pr auto review根据提供的代码更改,我注意到在多个QML文件中添加了 然而,没有提供具体的代码更改内容,所以我无法对代码逻辑、性能或安全性进行评估。以下是一些建议,供您参考:
如果您能提供具体的代码更改内容,我可以提供更详细的反馈。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caixr23 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to each file explaining why
QtQml.Modelsis needed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's Guide by SourceryThis pull request adds the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ListModel needs to import QtQml.Models
pms: BUG-307817
Summary by Sourcery
Bug Fixes: