Skip to content

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Apr 16, 2025

Airplane mode not monitoring Bluetooth status

pms: BUG-311349

Summary by Sourcery

Improve airplane mode detection by adding Bluetooth adapter monitoring

Bug Fixes:

  • Fix airplane mode not properly monitoring Bluetooth status by adding DBus signals for Bluetooth adapter changes

Enhancements:

  • Extend supportAirplaneMode() to check for Bluetooth adapters in addition to wireless network interfaces

Airplane mode not monitoring Bluetooth status

pms: BUG-311349
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的蓝牙和无线网络检查代码中,没有处理QDBusReply的错误情况,可能会导致未捕获的异常。
  • 新增的蓝牙和无线网络检查代码中,QJsonDocument::fromJson可能抛出异常,应该添加异常处理。
  • 新增的蓝牙和无线网络检查代码中,QJsonArray array = json.array();假设了json是一个数组,但没有进行类型检查,可能会导致运行时错误。
  • 新增的蓝牙和无线网络检查代码中,array[0].toObject()["Path"].toString().isEmpty()没有检查数组是否为空,可能会导致越界访问。

是否建议立即修改:

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 16, 2025

Reviewer's Guide by Sourcery

This pull request fixes an issue where airplane mode was not monitoring Bluetooth status. It adds D-Bus connections to listen for Bluetooth adapter changes and updates the supportAirplaneMode function to consider Bluetooth adapter availability when determining if airplane mode is supported.

Sequence diagram for Bluetooth adapter added

sequenceDiagram
    participant SystemBus as System Bus
    participant NetManagerThreadPrivate as NetManagerThreadPrivate

    SystemBus->>NetManagerThreadPrivate: AdapterAdded signal
    activate NetManagerThreadPrivate
    NetManagerThreadPrivate->>NetManagerThreadPrivate: getAirplaneModeEnabled()
    deactivate NetManagerThreadPrivate
Loading

Sequence diagram for Bluetooth adapter removed

sequenceDiagram
    participant SystemBus as System Bus
    participant NetManagerThreadPrivate as NetManagerThreadPrivate

    SystemBus->>NetManagerThreadPrivate: AdapterRemoved signal
    activate NetManagerThreadPrivate
    NetManagerThreadPrivate->>NetManagerThreadPrivate: getAirplaneModeEnabled()
    deactivate NetManagerThreadPrivate
Loading

File-Level Changes

Change Details Files
Added Bluetooth adapter monitoring to update airplane mode status.
  • Connected to Bluetooth adapter signals to trigger airplane mode status updates.
  • Modified the supportAirplaneMode function to check for Bluetooth adapter availability.
net-view/operation/private/netmanagerthreadprivate.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the bluetooth adapter check into a separate helper function for better readability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 88bfbc6 into linuxdeepin:master Apr 16, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants