-
Notifications
You must be signed in to change notification settings - Fork 48
fix: Airplane mode not monitoring Bluetooth status #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Airplane mode not monitoring Bluetooth status pms: BUG-311349
deepin pr auto review关键摘要:
是否建议立即修改: |
Reviewer's Guide by SourceryThis pull request fixes an issue where airplane mode was not monitoring Bluetooth status. It adds D-Bus connections to listen for Bluetooth adapter changes and updates the supportAirplaneMode function to consider Bluetooth adapter availability when determining if airplane mode is supported. Sequence diagram for Bluetooth adapter addedsequenceDiagram
participant SystemBus as System Bus
participant NetManagerThreadPrivate as NetManagerThreadPrivate
SystemBus->>NetManagerThreadPrivate: AdapterAdded signal
activate NetManagerThreadPrivate
NetManagerThreadPrivate->>NetManagerThreadPrivate: getAirplaneModeEnabled()
deactivate NetManagerThreadPrivate
Sequence diagram for Bluetooth adapter removedsequenceDiagram
participant SystemBus as System Bus
participant NetManagerThreadPrivate as NetManagerThreadPrivate
SystemBus->>NetManagerThreadPrivate: AdapterRemoved signal
activate NetManagerThreadPrivate
NetManagerThreadPrivate->>NetManagerThreadPrivate: getAirplaneModeEnabled()
deactivate NetManagerThreadPrivate
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caixr23 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the bluetooth adapter check into a separate helper function for better readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Airplane mode not monitoring Bluetooth status
pms: BUG-311349
Summary by Sourcery
Improve airplane mode detection by adding Bluetooth adapter monitoring
Bug Fixes:
Enhancements: