fix: Modifying the opening and closing of VPN caused a crash issue

[caixr23]

Unfolding item error caused when VPN does not exist

pms: BUG-313961

Summary by Sourcery

Fix potential crash and improve stability in network view item handling by adding null checks and preventing duplicate signal connections

Bug Fixes:

• Prevent potential crash when accessing network items with invalid model indexes
• Ensure safe handling of VPN and network item expansions by adding additional null checks

Enhancements:

• Improve signal connection robustness by using Qt::UniqueConnection to prevent multiple connections
• Add parent validation in model index retrieval to prevent potential null pointer access

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 在NetItemPrivate构造函数中新增了m_parent成员变量的初始化，这是一个好的做法，确保了对象在创建时所有成员变量都有明确的初始值。

2. 在NetView构造函数中，注释掉的代码被取消注释，这可能会影响滚动行为。如果取消注释的代码是故意为之，应该确保相关的滚动逻辑已经过充分测试。如果这部分代码不再需要，建议将其彻底删除。

3. 在NetView::rowsInserted函数中，对connect函数的调用添加了Qt::UniqueConnection标志，这是一个好的实践，可以避免重复连接信号和槽，防止潜在的内存泄漏。

4. 在NetView::updateItemExpand函数中，添加了对QModelIndex的有效性检查，这是一个重要的安全措施，可以防止在无效的索引上进行操作。

5. 在NetModel::index函数中，添加了对ancestor的检查，确保只有m_treeRoot的直接子节点才会被返回。这是一个合理的检查，可以避免返回错误的索引。

总体来说，代码的修改是合理的，没有发现明显的语法或逻辑错误。但是，对于注释掉的代码，需要进一步确认其用途和影响，以确保不会引入新的问题。

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a crash issue related to VPN connections. The changes include ensuring unique signal connections to prevent duplicate calls, validating model indexes before expanding items, and verifying parent-child relationships within the model. Additionally, the parent member of NetItemPrivate is initialized.

Sequence diagram for NetView::rowsInserted with VPNControlItem

sequenceDiagram
  participant NetView
  participant NetVPNControlItem

  NetView->>NetVPNControlItem: rowsInserted(parent, start, end)
  activate NetVPNControlItem
  NetVPNControlItem->NetView: connect(expandedChanged, onExpandStatusChanged, Qt::UniqueConnection)
  NetVPNControlItem->NetView: connect(enabledChanged, onExpandStatusChanged, Qt::UniqueConnection)
  NetVPNControlItem->NetView: updateItemExpand(vpnControlItem)
  deactivate NetVPNControlItem

Loading

Sequence diagram for NetView::rowsInserted with NetWirelessOtherItem

sequenceDiagram
  participant NetView
  participant NetWirelessOtherItem

  NetView->>NetWirelessOtherItem: rowsInserted(parent, start, end)
  activate NetWirelessOtherItem
  NetWirelessOtherItem->NetView: connect(expandedChanged, onExpandStatusChanged, Qt::UniqueConnection)
  NetWirelessOtherItem->NetView: updateItemExpand(otherItem)
  deactivate NetWirelessOtherItem

Loading

Sequence diagram for NetView::rowsInserted with NetDeviceItem

sequenceDiagram
  participant NetView
  participant NetDeviceItem
  participant NetWirelessDeviceItem

  NetView->>NetDeviceItem: rowsInserted(parent, start, end)
  activate NetDeviceItem
  NetDeviceItem->NetView: connect(enabledChanged, onExpandStatusChanged, Qt::UniqueConnection)
  NetDeviceItem->NetView: updateItemExpand(dev)
  alt dev->itemType() == NetType::WirelessDeviceItem
    NetDeviceItem->NetWirelessDeviceItem: apModeChanged
    NetWirelessDeviceItem->NetView: connect(apModeChanged, onExpandStatusChanged, Qt::UniqueConnection)
  end
  deactivate NetDeviceItem

Loading

Updated class diagram for NetItemPrivate

classDiagram
  class NetItemPrivate {
    -NetItem* m_item
    -NetItem* m_parent
    NetItemPrivate()
  }

Loading

File-Level Changes

Change	Details	Files
Ensured that signals connected to onExpandStatusChanged are uniquely connected to prevent multiple calls when the item is re-inserted.	Used Qt::UniqueConnection when connecting signals expandedChanged and enabledChanged of NetVPNControlItem to onExpandStatusChanged. Used Qt::UniqueConnection when connecting signal expandedChanged of NetWirelessOtherItem to onExpandStatusChanged. Used Qt::UniqueConnection when connecting signal enabledChanged of NetDeviceItem to onExpandStatusChanged. Used Qt::UniqueConnection when connecting signal apModeChanged of NetWirelessDeviceItem to onExpandStatusChanged.	net-view/window/netview.cpp
Added a check to ensure the model index is valid before expanding the item.	Added a check !sIndex.isValid() in NetView::updateItemExpand to prevent processing invalid indexes.	net-view/window/netview.cpp
Added a check to ensure that the parent is a direct child of the root node.	Added a check to ensure that the parent is a direct child of the root node in NetModel::index.	net-view/window/private/netmodel.cpp
Initialized m_parent to nullptr in the NetItemPrivate constructor.	Initialized m_parent to nullptr in NetItemPrivate::NetItemPrivate().	net-view/operation/private/netitemprivate.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @caixr23 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The addition of Qt::UniqueConnection looks good, but consider if a disconnect is needed when the items are removed.
• The isValid check in updateItemExpand is a good defensive addition.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment