fix: Abnormal issue with modifying network icons

[caixr23]

Abnormal issue with modifying network icons

pms: BUG-315507

Summary by Sourcery

Bug Fixes:

• Corrected the rectangle used when filling the pixmap to resolve icon rendering problems

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 修改了 fillRect 方法的调用，将参数从 r 改为 pm.rect()，确保填充整个 QPixmap 区域。

是否建议立即修改:

• 否，这次提交的修改是合理的，没有发现需要立即修改的问题。但是，建议进行以下额外的检查和改进：

1. 代码注释：添加或更新代码注释，解释为什么需要填充整个 QPixmap 区域，以及这样做的原因。
2. 测试：确保修改后的代码通过了所有相关的单元测试和集成测试，以验证更改不会引入新的问题。
3. 代码审查：如果这是多人协作的项目，建议进行代码审查，以获取其他开发者的反馈和意见。

[sourcery-ai]

Reviewer's Guide

The pull request addresses an issue with network icon modification by adjusting the drawing logic in the paintEvent method of the NetIconButton class. Specifically, it changes the rectangle used for filling when text is applied to an icon.

Updated Class Diagram for NetIconButton

classDiagram
  class NetIconButton {
    +paintEvent(QPaintEvent *e) void
    %% Other members and methods not shown for brevity %%
  }
  note for NetIconButton "paintEvent() method updated:\nLogic for fillRect changed when m_textType is true.\n- pa.fillRect(r, ...) changed to pa.fillRect(pm.rect(), ...)\nto fix icon rendering with text."

Loading

File-Level Changes

Change	Details	Files
Corrected the drawing area for text on network icons.	Modified pa.fillRect in NetIconButton::paintEvent to use the pixmap's full rectangle (pm.rect()) instead of a potentially smaller rectangle (r) when m_textType is true, ensuring the entire icon area is correctly processed for text rendering.	net-view/window/private/neticonbutton.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @caixr23 - I've reviewed your changes - here's some feedback:

• Now that m_textType consistently results in a full icon color overlay, consider if its name optimally conveys this specific visual effect.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment