-
Notifications
You must be signed in to change notification settings - Fork 48
fix: Block application proxy menu #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Block application proxy menu pms: BUG-315249
deepin pr auto review在提供的代码更改中,注释掉了将 建议:
代码质量:
代码性能:
代码安全:
总的来说,需要进一步了解为什么这行代码被注释掉,以及是否有替代逻辑来处理 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caixr23 - I've reviewed your changes - here's some feedback:
- Clarify if this code block is temporary (add
TODOwith context) or permanent (remove the commented-out code).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThe pull request disables the application proxy menu by commenting out the QML code that assigns the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Block application proxy menu
pms: BUG-315249
Summary by Sourcery
Bug Fixes: