-
Notifications
You must be signed in to change notification settings - Fork 48
fix: add transifex config #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deepin pr auto review代码审查意见:
总体来说,这次代码提交主要是配置文件的格式转换和重构,没有明显的语法或逻辑错误。但是,需要注意配置项的重复和文件路径的正确性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caixr23 - I've reviewed your changes - here's some feedback:
- This PR removes the
.tx/configfile; please clarify how developers should performtx push/pulloperations locally after this change. - The Transifex GitHub integration documentation suggests placing its config at
.transifex.yaml(root) or.github/transifex.yaml; please verify if.tx/transifex.yamlis a supported location for this.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis pull request transitions Transifex configuration to a new YAML-based file ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
add transifex config pms: TASK-361719
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, caixr23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
add transifex config
pms: TASK-361719
Summary by Sourcery
Chores: