Skip to content

Conversation

@yixinshark
Copy link
Contributor

@yixinshark yixinshark commented Jun 23, 2025

When the Active of login1 is changed to false,
it will not cause the ActiveChanged signal to send because it is the same as the default value.
This is a DTK bug and the default value is not initialized.

Log: as title
Pms: BUG-321333

Summary by Sourcery

Bug Fixes:

  • Initialize the login1 session's active state on startup to ensure the ActiveChanged signal fires when changing to false after a restart.

When the Active of login1 is changed to false,
it will not cause the ActiveChanged signal to send
because it is the same as the default value.
This is a DTK bug and the default value is not initialized.

Log: as title
Pms: BUG-321333
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 23, 2025

Reviewer's Guide

Adds manual invocation of the login1 Session Active interface during SessionManager's initConnections to initialize the default value and ensure ActiveChanged fires correctly (workaround for a DTK bug with uninitialized default).

File-Level Changes

Change Details Files
Initialize login1 session's default Active state to ensure ActiveChanged is emitted when false
  • Call m_login1SessionInter->active() in initConnections
  • Add Q_UNUSED(active) to suppress unused variable warning
  • Add explanatory TODO comment about DTK bug
src/dde-session/impl/sessionmanager.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SessionManager::initConnections函数中新增的代码块似乎没有实际作用,因为active变量被声明后立即被Q_UNUSED宏忽略,没有进行任何操作。
  • 注释中提到了一个DTK的bug,但没有提供修复的代码或解决方案。

是否建议立即修改:

建议的修改:

  • 移除新增的代码块,因为它没有实际功能。
  • 如果需要处理ActiveChanged信号,应该在注释中提供相应的解决方案或修复代码。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yixinshark - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 9033761 into linuxdeepin:master Jun 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants