Skip to content

Conversation

@18202781743
Copy link
Contributor

It caused other screen's maxed window hide when show the window,
and it's only a flag when exclusion zone is less zero in x11.

pms: TASK-365879

yixinshark
yixinshark previously approved these changes Dec 31, 2024
It caused other screen's maxed window hide when show the window,
and it's only a flag when exclusion zone is less zero in x11.

pms: TASK-365879
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • onExclusionZoneChanged函数中新增的代码检查m_dlayerShellWindow->exclusionZone()是否小于等于0,如果是则直接返回。这可能是为了防止无效的排除区域值导致后续代码执行错误。

是否建议立即修改:

  • 否,当前提交的代码改动看起来是合理的,没有明显的语法或逻辑错误。但是,建议进行以下几点改进:
    • 添加注释说明为什么需要检查exclusionZone()的值,以及这个检查的目的。
    • 确保这个改动不会影响现有的功能,并且已经通过了充分的测试。
    • 如果exclusionZone()的值小于等于0是一个常见的错误情况,可以考虑在更早的阶段捕获并处理,而不是在onExclusionZoneChanged函数中直接返回。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 35d3aa7 into linuxdeepin:master Dec 31, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants