Skip to content

fix: start a timer in another thread #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Feb 13, 2025
Merged

fix: start a timer in another thread #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions panels/notification/server/notificationmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,8 @@ void NotificationManager::onHandingPendingEntities()
// find last point to restart pendingTimeout
m_lastTimeoutPoint = points.first();
auto newInterval = m_lastTimeoutPoint - current;
m_pendingTimeout->setInterval(newInterval);
m_pendingTimeout->start();
// let timer start in main thread
Copy link
Contributor

@18202781743 18202781743 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

出问题的是从主线程调过来的吧，timer应该一直是子线程的，

QMetaObject::invokeMethod(m_pendingTimeout, "start", Qt::QueuedConnection, Q_ARG(int, newInterval));
} else {
// reset m_lastTimeoutPoint
m_lastTimeoutPoint = std::numeric_limits<qint64>::max();
Expand Down