feat: adjust OSD ui according to v25 #1068
Conversation
Reviewer's Guide by SourceryThis pull request updates the OSD UI to match the v25 design specifications. It includes changes to the layout, styling, and component usage of various OSD applets, such as window effect, display mode, audio, brightness, keyboard layout, and default notifications. The test script was also updated to use the correct D-Bus destination and interface. Updated class diagram for AppletItemclassDiagram
class AppletItem {
implicitWidth: int
implicitHeight: int
singleView: bool
selectIndex: int
checkedIndex: int
update(osdType)
match(osdType)
indexByValue(value)
}
note for AppletItem "Added singleView property and updated implicitWidth and implicitHeight"
Updated class diagram for D.ItemDelegateclassDiagram
class D.ItemDelegate {
padding: int
spacing: int
checkable: bool
index: int
iconName: string
title: string
description: string
backgroundColor: D.Palette
checkedBackgroundColor: D.Palette
dropShadowColor: D.Palette
innerShadowColor: D.Palette
isCurrent: bool
}
note for D.ItemDelegate "Added properties for styling and current state"
Updated class diagram for D.ProgressBarclassDiagram
class D.ProgressBar {
from: real
value: real
to: real
contentColor: D.Palette
backgroundColor: D.Palette
}
note for D.ProgressBar "Added properties for styling"
Updated class diagram for WindowclassDiagram
class Window {
visible: bool
osdView: Item
isSingleView: bool
}
note for Window "Added isSingleView property"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider defining a standard height for
AppletItemto ensure consistent sizing across different OSD types. - It looks like you're adding shadows to the items - make sure these work well with dark and light themes.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| Component.onCompleted: { | ||
| Qt.callLater(function () { | ||
| view.implicitWidth = view.maxItemWidth() |
There was a problem hiding this comment.
suggestion: Recalculate ListView implicitWidth on model changes.
Currently the implicitWidth is updated only after the delegate’s completion. It might be beneficial to also update it when the model changes to handle dynamic content sizing.
Suggested implementation:
model: Applet.layouts
onCountChanged: {
Qt.callLater(function () {
view.implicitWidth = view.maxItemWidth()
})
}
Ensure that the ListView element has an id "view" so that the above changes correctly reference it. Also, if there are any other parts of the code which manipulate the model, double-check that the implicitWidth is recalculated appropriately.
deepin pr auto review代码审查意见：
|
According to v25 in sketch. sketch.com/s/af485842-d50e-4969-9c0c-e027cfc7c0d2
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
4 participants
According to v25 in sketch.
sketch.com/s/af485842-d50e-4969-9c0c-e027cfc7c0d2
Summary by Sourcery
Update OSD (On-Screen Display) UI components to match v25 design specifications, improving visual consistency and user experience across different notification panels.
New Features:
Enhancements:
Chores: