-
Notifications
You must be signed in to change notification settings - Fork 55
fix: adjust UI for osd #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust UI for osd #1080
Conversation
1.Update icons. 2.Update background of Window. 3.Update items background for listview. pms: BUG-311127
Reviewer's Guide by SourceryThis pull request focuses on improving the UI of the OSD (On-Screen Display) by updating icons, adjusting the background of the Window, and refining the appearance of items within list views. The changes involve modifications to color palettes, shadow effects, and background components to enhance visual clarity and aesthetics. Updated class diagram for AppletItemclassDiagram
class AppletItem {
-property string iconName
-property string title
-property string description
+property bool isCurrent
-property D.Palette backgroundColor
-property D.Palette checkedBackgroundColor
-property D.Palette dropShadowColor
-property D.Palette innerShadowColor
}
note for AppletItem "Added property 'isCurrent'"
note for AppletItem "Updated properties 'dropShadowColor' and 'innerShadowColor'"
Updated class diagram for WindowclassDiagram
class Window {
-property D.FloatingPanel background
}
class D.FloatingPanel {
+property D.Palette backgroundColor
+property D.Palette insideBorderColor
+property D.Palette outsideBorderColor
+property D.Palette dropShadowColor
}
note for D.FloatingPanel "Added properties 'backgroundColor', 'insideBorderColor', 'outsideBorderColor', and 'dropShadowColor'"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
总体来说,这些修改看起来是为了调整UI的视觉效果和交互行为,需要确保这些更改符合设计规范和功能需求。同时,应该更新相关的文档和注释,以便其他开发者能够理解这些更改。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider defining the color palettes in a central location to avoid duplication.
- It might be good to use a consistent naming scheme for the color palette properties.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
1.Update icons.
2.Update background of Window.
3.Update items background for listview.
pms: BUG-311127
Summary by Sourcery
Refactor and update the UI for on-screen display (OSD) components, adjusting visual styles and color palettes across multiple QML files.
Bug Fixes:
Enhancements: