-
Notifications
You must be signed in to change notification settings - Fork 55
fix: incorrect window shadow height for osd #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adjust shadowOffset by UI designer to avoid shadow height is not enough. pms: BUG-310841
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryThis pull request adjusts the shadow offset and color of the OSD window to ensure the shadow height is visually correct, according to UI designer specifications. The shadow color is now theme-dependent, using a darker shade for the dark theme and a lighter shade for the light theme. The shadow offset was also modified. Updated class diagram for Window in main.qmlclassDiagram
class Window {
D.DWindow.windowRadius: int
D.DWindow.enableBlurWindow: bool
D.DWindow.enabled: bool
+D.DWindow.shadowOffset: Qt.point
+D.DWindow.shadowColor: Qt.rgba
color: string
DLayerShellWindow.bottomMargin: int
DLayerShellWindow.layer: DLayerShellWindow.LayerOverlay
}
note for Window "Adjusted shadowOffset and shadowColor properties for better visual appearance."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making the shadow offset configurable to avoid hardcoding the value.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Adjust shadowOffset by UI designer to avoid shadow height is
not enough.
pms: BUG-310841
Summary by Sourcery
Bug Fixes: