-
Notifications
You must be signed in to change notification settings - Fork 55
fix: translations is inconsistent with dde-control-center for osd #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
as title. pms: BUG-301193
Reviewer's Guide by SourceryThis pull request updates the descriptions for the 'Optimal performance', 'Balance', and 'Best Visuals' modes in the window effect settings to align with the dde-control-center. The changes involve modifying the translation files and the main QML file to reflect the updated descriptions. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
综上所述,代码的修改主要是为了提高描述的清晰度和一致性,但需要注意注释的添加、翻译的一致性、文件路径和行号的准确性,以及代码风格的统一。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like the location of the strings in main.qml has changed - is this intentional?
- This PR touches a lot of translation files - is there a way to automate this process?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
as title.
pms: BUG-301193
Summary by Sourcery
Update translations for window effect descriptions to improve clarity and consistency across languages
Bug Fixes:
Documentation: