-
Notifications
You must be signed in to change notification settings - Fork 55
fix: bluetooth still entered notificationcenter #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request filters Bluetooth notifications related to file transfers from being displayed in the notification center. The filtering logic was moved from No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test for the
filterToSourcemethod to ensure it correctly identifies Bluetooth notifications. - It might be helpful to add a comment explaining why the bluetooth notification is being filtered.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review当然,我很乐意帮助您审查代码。请提供您想要审查的代码或Git diff输出。 |
Filting bluetooth notification in DataAccessorProxy.
pms: BUG-311617
Summary by Sourcery
Improve handling of Bluetooth file transfer notifications to prevent them from appearing in the notification center
Bug Fixes:
Enhancements: