Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Apr 14, 2025

Filting bluetooth notification in DataAccessorProxy.

pms: BUG-311617

Summary by Sourcery

Improve handling of Bluetooth file transfer notifications to prevent them from appearing in the notification center

Bug Fixes:

  • Fix Bluetooth notifications incorrectly appearing in the notification center by adding a filter mechanism

Enhancements:

  • Introduce a new filterToSource method in DataAccessorProxy to detect and filter out Bluetooth file transfer notifications

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 14, 2025

Reviewer's Guide by Sourcery

This pull request filters Bluetooth notifications related to file transfers from being displayed in the notification center. The filtering logic was moved from NotificationManager to DataAccessorProxy for better organization and reusability.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implemented a filter to prevent Bluetooth notifications related to file transfers from being displayed in the notification center.
  • Added a filterToSource method to check if a notification should be filtered based on its content and actions.
  • Modified addEntity and updateEntityProcessedType to use the new filter.
  • The filter checks if the notification body contains '%' and the actions contain 'cancel', indicating a Bluetooth file transfer notification.
panels/notification/common/dataaccessorproxy.cpp
panels/notification/common/dataaccessorproxy.h
Removed Bluetooth-specific filtering logic from NotificationManager.
  • Removed the Bluetooth notification filtering condition from the updateEntityProcessed method.
panels/notification/server/notificationmanager.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a unit test for the filterToSource method to ensure it correctly identifies Bluetooth notifications.
  • It might be helpful to add a comment explaining why the bluetooth notification is being filtered.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

当然,我很乐意帮助您审查代码。请提供您想要审查的代码或Git diff输出。

@deepin-bot deepin-bot bot merged commit 7ed73e9 into linuxdeepin:master Apr 15, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants