-
Notifications
You must be signed in to change notification settings - Fork 55
fix: elements not aligned correctly when dock resize #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
修复用户拖拽 dock 调整高度时,dock内元素未居中的问题. PMS: BUG-312831 Log:
|
Skipping CI for Draft Pull Request. |
Reviewer's Guide by SourceryThis pull request fixes an issue where elements within the dock were not correctly aligned when the dock was resized by the user. The primary changes involve correcting the dock container sizing and ensuring the tray height is consistent with the dock size during resizing. Updated class diagram for Dock and Tray componentsclassDiagram
class Dock {
-dockSize : int
-useColumnLayout : bool
}
class Tray {
-useColumnLayout : bool
-implicitHeight : int
-implicitWidth : int
}
class Panel {
+rootObject : Dock
}
Dock -- DockContainer : contains
Tray -- AppletItem : contains
AppletItem -- Panel : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's good to see the bug fix, but the commit message could be improved to be more descriptive.
- Consider adding a comment explaining why
Panel.rootObject.dockSizeis used instead oftray.implicitWidth.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
修复用户拖拽 dock 调整高度时,dock内元素未居中的问题.
PMS: BUG-312831
Log:
Summary by Sourcery
Fix alignment and sizing issues in the dock panel when resizing
Bug Fixes: