fix: The icons residing on pannel move from right side to left side.

[wjyrich]

set a flag for NumberAnimation.

pms: BUG-309403

Summary by Sourcery

Bug Fixes:

• Prevent layout animations from interfering with dock dragging by adding a conditional flag to NumberAnimation behaviors

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 代码格式和风格：

   • 在新增的enabled属性后添加了空格，这有助于提高代码的可读性。但是，建议在整个项目中保持一致的代码风格，比如是否在enabled属性后添加空格。

2. 逻辑和功能：

   • 新增的enabled属性用于控制动画行为，只有在dock.isDragging为false时，动画才会生效。这是一个合理的改动，因为它确保了在拖动时不会触发动画，从而避免了不必要的性能开销。

3. 性能：

   • 没有明显的性能问题，但是建议在动画开始前检查dock.isDragging的值，以避免在不需要的时候创建动画对象。虽然这不会显著影响性能，但有助于减少内存使用。

4. 安全性：

   • 代码中没有涉及到安全性问题，因为这是一个QML文件，主要处理用户界面逻辑。

5. 可维护性：

   • 新增的enabled属性使得动画行为更加清晰，易于理解和维护。但是，如果将来需要添加更多的动画行为，建议将这部分逻辑抽象成一个函数或组件，以提高代码的复用性和可维护性。

6. 注释：

   • 虽然代码改动较小，但建议在新增的enabled属性附近添加注释，解释为什么需要这个改动，以及它如何影响用户体验。

总体来说，这次代码提交是合理的，没有明显的错误或问题。只要保持代码风格的一致性，并且添加必要的注释，代码将更加健壮和易于维护。

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request modifies the animation behavior of the dock's layout margins. Animations are now disabled when the dock is being dragged, preventing the icons from moving unexpectedly during drag operations. This is achieved by adding an enabled property to the NumberAnimation elements for both Layout.leftMargin and Layout.topMargin, and setting it to !dock.isDragging.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Conditionally enable animations for layout margins based on the dragging state of the dock.	Added an enabled property to the NumberAnimation for Layout.leftMargin. The enabled property is set to !dock.isDragging, disabling the animation when the dock is being dragged. Added an enabled property to the NumberAnimation for Layout.topMargin. The enabled property is set to !dock.isDragging, disabling the animation when the dock is being dragged.	panels/dock/package/main.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @wjyrich - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the NumberAnimation configuration into a reusable component or function to avoid repetition.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment