fix: dnd does not disable to play sound for notification

[18202781743]

it's the action in v23, we handle it according v20.

pms: BUG-310921

Summary by Sourcery

Bug Fixes:

• Prevent playing system notification sounds when in Do Not Disturb mode

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 删除了 systemNotification && dndMode 条件下的 playSoundTip = true; 语句，可能会影响通知声音的播放逻辑。

是否建议立即修改:

• 是，需要确认删除该条件是否是有意为之，以及是否会影响预期的功能。如果这是有意为之，应该添加相应的注释说明原因。如果这是无意的，应该恢复该逻辑以保持原有的功能。

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug where notification sounds were incorrectly playing during Do Not Disturb mode. The change removes a condition that was causing system notifications to bypass the DND setting and play sounds.

Sequence diagram for notification sound playback with DND mode

sequenceDiagram
  participant NotificationManager
  participant SystemSettings

  NotificationManager->>SystemSettings: Check DND mode
  alt DND mode is off
    NotificationManager->>NotificationManager: Play notification sound
  else DND mode is on
    NotificationManager->>NotificationManager: Do not play notification sound
  end

Loading

File-Level Changes

Change	Details	Files
The pull request modifies the conditions under which notification sounds are played when the system is in Do Not Disturb (DND) mode.	Removes a condition that would force notification sounds to play even when DND mode is active for system notifications.	panels/notification/server/notificationmanager.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

• It's not clear to me why the systemNotification && dndMode check was removed - can you add a comment explaining this?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[18202781743]

/forcemerge

[deepin-bot]

This pr force merged! (status: blocked)