Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Apr 17, 2025

  • chore: missing some translations for notification (BUG-289337)
  • fix: compatibility with Qt 6.9+
  • fix: elements not aligned correctly when dock resize (BUG-312831)
  • fix: need update exclusion zone when screen was added or removed (BUG-306339)
  • fix: bluetooth still entered notificationcenter (BUG-311617)
  • fix: The icons residing on pannel move from the right side to the left side (BUG-309403)
  • fix: dnd does not disable to play sound for notification (BUG-310921)

Log:

Summary by Sourcery

Prepare release of dde-shell version 1.99.32 with multiple bug fixes

Bug Fixes:

  • Fix compatibility issues with Qt 6.9+
  • Resolve panel element alignment problems when dock is resized
  • Update exclusion zone handling when screens are added or removed
  • Correct Bluetooth notification center behavior
  • Fix icon positioning on panel
  • Address Do Not Disturb sound notification settings

Chores:

  • Update changelog for release 1.99.32
  • Address missing translations for notifications

@BLumia BLumia requested review from robertkill and yixinshark April 17, 2025 09:48
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This release focuses on bug fixes and compatibility improvements for dde-shell, including translation updates, Qt 6.9+ compatibility, and fixes for UI and notification-related issues.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Addressed multiple bug fixes and compatibility improvements.
  • Fixed missing translations for notifications.
  • Ensured compatibility with Qt 6.9+.
  • Corrected alignment issues when the dock is resized.
  • Updated exclusion zone when screens are added or removed.
  • Prevented Bluetooth from incorrectly entering the notification center.
  • Resolved an issue where icons on the panel moved unexpectedly.
  • Fixed a problem where 'do not disturb' mode didn't disable notification sounds.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

TAG Bot

TAG: 1.99.32
EXISTED: no
DISTRIBUTION: UNRELEASED

  * chore: missing some translations for notification (BUG-289337)
  * fix: compatibility with Qt 6.9+
  * fix: elements not aligned correctly when dock resize (BUG-312831)
  * fix: need update exclusion zone when screen was added or removed
    (BUG-306339)
  * fix: bluetooth still entered notificationcenter (BUG-311617)
  * fix: The icons residing on pannel move from the right side to the left side
    (BUG-309403)
  * fix: dnd does not disable to play sound for notification (BUG-310921)

Log:
@deepin-ci-robot
Copy link

deepin pr auto review

这个提交的changelog文件记录了dde-shell版本1.99.32的更新内容。从提交信息来看,主要修复了一些问题,并添加了一些翻译。以下是对这个提交的一些改进建议:

  1. 版本号格式:版本号1.99.32可能不符合常见的语义化版本控制规范(Semantic Versioning)。建议遵循主版本号.次版本号.修订号的格式,例如1.99.32可以改为1.99.33

  2. 提交信息格式:提交信息应该简洁明了,并且遵循一定的格式。例如,可以参考以下格式:

    dde-shell (1.99.33) UNRELEASED; urgency=medium
    
      * chore: 修复通知缺少翻译的问题 (BUG-289337)
      * fix: 修复与Qt 6.9+的兼容性问题
      * fix: 修复停靠栏调整大小时元素对齐问题 (BUG-312831)
      * fix: 更新屏幕添加或移除时排除区域
      * fix: 蓝牙仍然进入通知中心 (BUG-311617)
      * fix: 面板上的图标从右侧移动到左侧 (BUG-309403)
      * fix: 拖放时不禁用通知播放声音 (BUG-310921)
    
    -- Wang Zichong <[email protected]>  Thu, 17 Apr 2025 17:46:00 +0800
    
  3. BUG编号格式:BUG编号应该统一格式,例如BUG-后跟数字。如果项目中已经存在这样的格式,建议保持一致。

  4. 翻译缺失:提交信息中提到缺少翻译,建议在提交中添加具体的翻译内容,或者提供翻译的链接。

  5. 版本号更新:在提交信息中提到版本号更新,但实际文件中的版本号没有更新。建议在文件中更新版本号,以保持提交信息和实际版本号的一致性。

  6. 提交信息语言:提交信息中使用了中文,建议保持项目中的语言一致性。如果项目中有其他语言,建议使用相同的语言。

  7. 提交信息格式化:提交信息中的-- Wang Zichong <[email protected]> Thu, 17 Apr 2025 17:46:00 +0800部分可以格式化为:

    -- Wang Zichong <[email protected]>  Thu, 17 Apr 2025 17:46:00 +0800
    

综上所述,这个提交的changelog文件在格式和内容上存在一些问题,建议按照上述建议进行修改。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 52fe31a into linuxdeepin:master Apr 17, 2025
8 of 11 checks passed
@BLumia BLumia deleted the release/1.99.32 branch April 17, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants