Skip to content

Conversation

@yixinshark
Copy link
Contributor

@yixinshark yixinshark commented Apr 17, 2025

Configure name retrieval in three levels

fix-Bug-translation

Summary by Sourcery

Improve language code handling for application translations by adding a more flexible method to retrieve localized names

Bug Fixes:

  • Fix translation retrieval by supporting fallback to language code prefix when exact language code is not found

Enhancements:

  • Add a new method to handle language code variations when retrieving localized names
  • Improve localization name resolution for actions, names, and generic names

Configure name retrieval in three levels

fix-Bug-translation
@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This pull request introduces a fallback mechanism for retrieving application names, generic names, and action names based on the system's locale. It first tries to find a direct match for the full locale (e.g., en_US). If that fails, it falls back to the language code (e.g., en). If both fail, it returns an empty string, which will trigger the use of the default name.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implemented a three-level fallback mechanism for retrieving localized names based on the current system language.
  • Added a helper function getLocaleName to handle the locale name retrieval logic.
  • The getLocaleName function first attempts to retrieve the name using the full locale code (e.g., 'en_US').
  • If the full locale code is not found and it contains a country code, it attempts to retrieve the name using only the language code (e.g., 'en').
  • If neither the full nor the language-only locale code is found, it returns an empty string.
  • The updateLocalName, updateLocalGenericName and updateActions methods now use the getLocaleName helper function to retrieve the localized names.
panels/dock/taskmanager/desktopfileamparser.cpp
panels/dock/taskmanager/desktopfileamparser.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@yixinshark yixinshark closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants