-
Notifications
You must be signed in to change notification settings - Fork 55
fix: [Font-size] The Font size can not change by dde-control-center. #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Font-size] The Font size can not change by dde-control-center. #1105
Conversation
-- Dtk enables the font size of upper-layer applications to change with the control center through DApplication. -- The desktop program has embedded dde-shell, but dde-shell uses QApplication, causing the font size of upper-layer applications not to follow changes when the control center's font size is adjusted. -- Modify dde-shell's QApplication to DApplication. Log: fix issue Bug: https://pms.uniontech.com/bug-view-285621.html
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryThis pull request modifies Sequence diagram for font size change propagationsequenceDiagram
actor User
participant ControlCenter
participant DApplication
participant UpperLayerApp
User->>ControlCenter: Adjusts font size
ControlCenter->>DApplication: Sets new font size
DApplication->>UpperLayerApp: Propagates font size change
UpperLayerApp->>UpperLayerApp: Updates UI with new font size
Updated class diagram for QApplication and DApplicationclassDiagram
class QApplication {
-- Removed --
}
class DApplication {
-- Added --
}
DApplication --|> QApplication : inherits from
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GongHeng2017 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
UseInactiveColorGroupis being set to false. - It might be helpful to add a brief explanation about why
QT_SCALE_FACTORis being unset.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@BLumia 麻烦review一下 |
|
Commit message 需要改成 @18202781743 这里只能用 dtkwidget 的 DApplication 吗? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, GongHeng2017 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fontSize 在DApplication里做的,不然的话widget的很多应用用之前的接口就有问题了,需要手动去用dtkgui的实现, |
-- Dtk enables the font size of upper-layer applications to change with the control center
through DApplication.
-- The desktop program has embedded dde-shell, but dde-shell uses QApplication, causing the
font size of upper-layer applications not to follow changes when the control center's font
size is adjusted.
-- Modify dde-shell's QApplication to DApplication.
Log: fix issue
PMS: BUG-285621
Summary by Sourcery
Replace QApplication with DApplication in dde-shell to enable font size synchronization with the control center
Bug Fixes:
Enhancements:
Build: