-
Notifications
You must be signed in to change notification settings - Fork 55
fix: adjust ui of title for notification #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add DropShadow for text. pms: BUG-313195
Reviewer's Guide by SourceryThis pull request introduces a new Class diagram for NotifyHeaderTitleTextclassDiagram
class NotifyHeaderTitleText {
property font tFont
font
color
layer.enabled
layer.effect
}
Text <|-- NotifyHeaderTitleText
NotifyHeaderTitleText -- DropShadow : layer.effect
note for NotifyHeaderTitleText "Adds a drop shadow to the text"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
综上所述,建议对新增的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider renaming
tFonttotextFontfor better readability. - It might be beneficial to move the DropShadow effect to a separate file for reusability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Add DropShadow for text.
pms: BUG-313195
Summary by Sourcery
Refactor notification header text to use a new custom component with drop shadow effect
Bug Fixes:
Enhancements: