-
Notifications
You must be signed in to change notification settings - Fork 55
refactor: prepare for combined model for taskmanager #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactor introduces a unified proxy‐model pipeline and an abstract interface to prepare for a combined model in TaskManager, without altering existing behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes - here's some feedback:
- The stubbed-out AbstractTaskManagerInterface methods in DockGlobalElementModel (e.g. requestOpenUrls, requestUpdateWindowGeometry, requestWindowsView) are currently no-ops—either implement them or remove them to avoid silent failures.
- Avoid using synchronous QProcess::waitForFinished in DockGlobalElementModel::requestNewInstance since it blocks the UI thread; consider launching the process asynchronously or using a job API instead.
- In BoolFilterModel::filterAcceptsRow, the check
if (sourceRow > sourceModel()->rowCount())should use>=to correctly guard against out-of-range row indices.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0adae88 to
145b6a0
Compare
de92edc to
100ddf3
Compare
100ddf3 to
dd30123
Compare
panels/dock/taskmanager/dconfig/org.deepin.ds.dock.taskmanager.json
Outdated
Show resolved
Hide resolved
为后续多任务区域切换到新的合并模型做出准备. 目前的表现行为仍然和之前一致,无行为变化(taskmanager实际使用的仍然是原模型). Log:
dd30123 to
165193f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
为后续多任务区域切换到新的合并模型做出准备。
目前的表现行为仍然和之前一致,无行为变化(taskmanager实际使用的仍然是原模型)。
Summary by Sourcery
Refactor TaskManager to build a new combined data-model pipeline through proxy models and an abstract interface, enabling future multi-task area support without altering current behavior.
Enhancements:
Build: