-
Notifications
You must be signed in to change notification settings - Fork 55
fix: smart hide state not updated when window closed #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
修复关闭窗口时,智能隐藏状态未刷新的问题. PMS: BUG-317017 Log:
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideIntroduces a flag to detect window removals in onWindowClientListChanged and emits an overlap-change signal after removals to update smart-hide state when windows close. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
修复关闭窗口时,智能隐藏状态未刷新的问题.
Summary by Sourcery
Bug Fixes: