-
Notifications
You must be signed in to change notification settings - Fork 55
fix: incorrectly removed window in AbstractWindowMonitor #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe PR corrects the row removal notification in AbstractWindowMonitor’s destroyWindow method by matching the beginRemoveRows range to the actual single-element removal, avoiding model/view inconsistencies. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
AbstractWindowMonitor 在跟踪移除窗口事件时,对 model 状态的维护不正确, 实际移除的元素数量和beginRemoveRows中传递的数量不匹配,可能导致模型状态 有误导致的潜在崩溃或视图错误. 另外,也将原本的 removeOne 调整为 removeAt,以便准确移除给定位置的元素, 而非首个匹配但不一定在给定位置的元素. Log:
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
@BLumia: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, tsic404 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
AbstractWindowMonitor 在跟踪移除窗口事件时,对 model 状态的维护不正确, 实际移除的元素数量和beginRemoveRows中传递的数量不匹配,可能导致模型状态有误导致的潜在崩溃或视图错误.
Summary by Sourcery
Bug Fixes: