Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented May 22, 2025

  1. Removed redundant prefixes ("Optimal performance:", "Balance:", "Best visuals:") from descriptions in main.qml
  2. Updated translation files to match the simplified descriptions
  3. This change makes the UI text more concise while maintaining clarity
  4. The modification affects all language translations to ensure consistency

chore: 简化窗口特效描述文本

  1. 移除了 main.qml 中描述文本的多余前缀("最佳性能:"、"均衡:"、"最佳 视觉:")
  2. 更新翻译文件以匹配简化后的描述文本
  3. 这一改动使界面文本更加简洁同时保持清晰
  4. 修改影响了所有语言翻译以确保一致性

pms: BUG-313277

Summary by Sourcery

Simplify the window effect mode descriptions by removing redundant prefixes and update all translation files to reflect the new, concise text

Enhancements:

  • Remove redundant prefixes from window effect descriptions in the UI
  • Update translations across all languages to match the simplified descriptions

1. Removed redundant prefixes ("Optimal performance:", "Balance:", "Best
visuals:") from descriptions in main.qml
2. Updated translation files to match the simplified descriptions
3. This change makes the UI text more concise while maintaining clarity
4. The modification affects all language translations to ensure
consistency

chore: 简化窗口特效描述文本

1. 移除了 main.qml 中描述文本的多余前缀("最佳性能:"、"均衡:"、"最佳
视觉:")
2. 更新翻译文件以匹配简化后的描述文本
3. 这一改动使界面文本更加简洁同时保持清晰
4. 修改影响了所有语言翻译以确保一致性

pms: BUG-313277
@mhduiy mhduiy requested a review from 18202781743 May 22, 2025 07:33
@sourcery-ai
Copy link

sourcery-ai bot commented May 22, 2025

Reviewer's Guide

This PR streamlines window effect descriptions by removing mode-prefixes from the UI text in main.qml and synchronously updating all translation source files to match the new concise sentences.

File-Level Changes

Change Details Files
Simplify description texts in main.qml
  • Removed "Optimal performance:", "Balance:", and "Best visuals:" prefixes
  • Replaced prefixed strings with concise sentences in qsTr calls
panels/notification/osd/windoweffect/package/main.qml
Synchronize translation files with new descriptions
  • Removed old entries containing prefixed source texts
  • Inserted new entries with simplified strings
  • Retained or updated translations under each language context
panels/notification/osd/windoweffect/translations/org.deepin.ds.osd.windoweffect*.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented May 26, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented May 26, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 5b37e58 into linuxdeepin:master May 26, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants