-
Notifications
You must be signed in to change notification settings - Fork 55
fix: update tanslation with Lock dock. #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deepin pr auto review代码审查意见:
以上是针对提交的代码的一些初步审查意见,具体的改进建议可能需要根据代码的具体功能和上下文来确定。 |
Reviewer's GuideThis PR standardizes TS file formatting across multiple translation files, introduces the new “Lock the Dock” string in dock settings, and extends the taskmanager translations with a new global-element context for common actions. Class Diagram: New and Updated Translatable String ContextsclassDiagram
title Class Diagram: New and Updated Translatable String Contexts
class DockSettingsStrings {
+String Indicator Style
+String Fashion Mode
+String Efficient Mode
+String Classic Mode
+String Status
+String Position
+String Mode
+String Display Mode
+String Keep Shown
+String Keep Hidden
+String Smart Hide
+String Dock Settings
+String Lock the Dock (new)
}
class DockGlobalElementModelStrings {
+String Open (new)
+String Undock (new)
+String Dock (new)
+String Force Quit (new)
+String Close All (new)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- In panels/dock/translations/org.deepin.ds.dock.ts you’ve set the TS language attribute to “_CN”, which looks unintended—please remove or correct it so the base TS remains locale-neutral.
- Several TS files were updated with new XML headers but still lack a final newline—please ensure consistent XML declarations and end-of-file newlines to avoid parser errors.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
as title. Log:
891d72c to
3a3311a
Compare
|
@wjyrich: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
as title.
Log:
Summary by Sourcery
Update translation files for dock and notification panels: standardize TS XML headers and formatting, and add missing localization entries.
New Features:
Enhancements: