-
Notifications
You must be signed in to change notification settings - Fork 55
fix: The tray window panel automatically opens #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add popup visibility handler to ActionShowStashDelegate Introduce a Connections block to handle `stashedPopup.popupVisibleChanged` signal. When the popup is hidden and no item is being dragged, reset `dropHoverIndex` to -1. This ensures proper state management when the popup visibility changes. pms: BUG-317959
Reviewer's GuideImplements a Connections block to listen for stashedPopup.popupVisibleChanged, resetting dropHoverIndex to -1 when the popup closes without an active drag to maintain correct state management. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robertkill - I've reviewed your changes - here's some feedback:
- The description mentions logging the popup visibility change, but the handler only resets dropHoverIndex—consider adding a console.log call (or equivalent) inside onPopupVisibleChanged to record the event.
- Instead of a separate Connections block, you could define onPopupVisibleChanged directly on the stashedPopup element to keep the handler co-located and avoid null-target issues.
- Consider placing the visibility-changed handler adjacent to the stashedPopup declaration for better readability and context.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Introduce a Connections block to handle
stashedPopup.popupVisibleChangedsignal. When the popup is hidden and no item is being dragged, resetdropHoverIndexto -1. This ensures proper state management when the popup visibility changes.pms: BUG-317959
Summary by Sourcery
Bug Fixes: