Skip to content

fix: fix warnings. #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Jun 12, 2025
Merged

fix: fix warnings. #1154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions panels/dock/package/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Window {
property real dockItemIconSize: dockItemMaxSize * 9 / 14

// NOTE: -1 means not set its size, follow the platform size
width: Panel.position == Dock.Top || Panel.position == Dock.Bottom ? -1 : dockSize
height: Panel.position == Dock.Left || Panel.position == Dock.Right ? -1 : dockSize
width: Panel.position === Dock.Top || Panel.position === Dock.Bottom ? -1 : dockSize
height: Panel.position === Dock.Left || Panel.position === Dock.Right ? -1 : dockSize
color: "transparent"
flags: Qt.WindowDoesNotAcceptFocus

Expand Down Expand Up @@ -88,8 +88,8 @@ Window {
return dock.useColumnLayout ? "width" : "height";
}
to: {
if (useTransformBasedAnimation) return Panel.hideState != Dock.Hide ? 0 : ((Panel.position == Dock.Left || Panel.position == Dock.Top) ? -Panel.dockSize : Panel.dockSize);
return Panel.hideState != Dock.Hide ? Panel.dockSize : 1;
if (useTransformBasedAnimation) return Panel.hideState !== Dock.Hide ? 0 : ((Panel.position === Dock.Left || Panel.position === Dock.Top) ? -Panel.dockSize : Panel.dockSize);
return Panel.hideState !== Dock.Hide ? Panel.dockSize : 1;
}
duration: 500
easing.type: Easing.OutCubic
Expand All @@ -98,9 +98,9 @@ Window {
}
onStopped: {
if (useTransformBasedAnimation) {
dock.visible = ((dock.useColumnLayout ? dockTransform.x : dockTransform.y) == 0)
dock.visible = ((dock.useColumnLayout ? dockTransform.x : dockTransform.y) === 0)
} else {
dock.visible = ((dock.useColumnLayout ? dock.width : dock.height) != 1)
dock.visible = ((dock.useColumnLayout ? dock.width : dock.height) !== 1)
}
}
}
Expand Down Expand Up @@ -165,7 +165,7 @@ Window {
if (useTransformBasedAnimation) {
dock.visible = true;
} else {
dock.visible = ((dock.useColumnLayout ? dock.width : dock.height) != 1);
dock.visible = ((dock.useColumnLayout ? dock.width : dock.height) !== 1);
}
}
}
Expand Down Expand Up @@ -490,7 +490,7 @@ Window {
if (Panel.locked) {
return Qt.ArrowCursor
}
if (Panel.position == Dock.Top || Panel.position == Dock.Bottom) {
if (Panel.position === Dock.Top || Panel.position === Dock.Bottom) {
return Qt.SizeVerCursor
}
return Qt.SizeHorCursor
Expand Down Expand Up @@ -528,11 +528,11 @@ Window {
var changeAverage = recentDeltas.reduce(function(acc, val) { return acc + val; }, 0) / recentDeltas.length;

var newDockSize = 0
if (Panel.position == Dock.Bottom) {
if (Panel.position === Dock.Bottom) {
newDockSize = Math.min(Math.max(oldDockSize - changeAverage, Dock.MIN_DOCK_SIZE), Dock.MAX_DOCK_SIZE)
} else if (Panel.position == Dock.Top) {
} else if (Panel.position === Dock.Top) {
newDockSize = Math.min(Math.max(oldDockSize + changeAverage, Dock.MIN_DOCK_SIZE), Dock.MAX_DOCK_SIZE)
} else if (Panel.position == Dock.Left) {
} else if (Panel.position === Dock.Left) {
newDockSize = Math.min(Math.max(oldDockSize + changeAverage, Dock.MIN_DOCK_SIZE), Dock.MAX_DOCK_SIZE)
} else {
newDockSize = Math.min(Math.max(oldDockSize - changeAverage, Dock.MIN_DOCK_SIZE), Dock.MAX_DOCK_SIZE)
Expand Down