-
Notifications
You must be signed in to change notification settings - Fork 55
fix: sort notifications by timestamp before display #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added sorting of notification entities by creation time (cTime) in descending order 2. Ensures newest notifications appear first in the list 3. Improves user experience by showing most recent notifications at the top 4. Sorting happens before the model reset to maintain data consistency fix: 在显示前按时间戳排序通知 1. 添加了按创建时间(cTime)降序排列通知实体的功能 2. 确保最新的通知显示在列表最前面 3. 通过将最新通知显示在顶部来提升用户体验 4. 排序操作在模型重置前完成以保持数据一致性 pms:BUG-299935
Reviewer's GuideImplements sorting of notification entities in descending order by creation time before model reset, ensuring newest notifications are displayed first. Class diagram for NotifyStagingModel and NotifyEntity after sorting changeclassDiagram
class NotifyStagingModel {
+void open()
entities: std::vector<NotifyEntity>
}
class NotifyEntity {
+qint64 cTime()
}
NotifyStagingModel "1" *-- "many" NotifyEntity: manages
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review关键摘要:
是否建议立即修改:
其他建议:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
descending order
the top
fix: 在显示前按时间戳排序通知
pms:BUG-299935
Summary by Sourcery
Bug Fixes: